fix: [code-1991]: fix padding and scroll (#2119)

harness · Jun 17, 2024 · 71d37cc · 71d37cc
1 parent 4c49244
commit 71d37cc
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/...es/PullRequest/Conversation/PullRequestOverviewPanel/PullRequestOverviewPanel.module.scss b/...es/PullRequest/Conversation/PullRequestOverviewPanel/PullRequestOverviewPanel.module.scss
@@ -86,7 +86,7 @@
 
 .requiredContainer {
  display: inline-flex !important;
- padding: 0px 6px 0.5px 6px !important;
+ padding: 0px 11px 0.5px 11px !important;
  justify-content: center !important;
  align-items: center !important;
  gap: 10px !important;
@@ -189,7 +189,7 @@
 }
 
 .paddingWithOutReq {
- padding-right: 4rem !important;
+ padding-right: 4.15rem !important;
 }
 
 .changeContainerPadding {

diff --git a/web/src/pages/PullRequest/Conversation/PullRequestOverviewPanel/sections/ChangesSection.tsx b/web/src/pages/PullRequest/Conversation/PullRequestOverviewPanel/sections/ChangesSection.tsx
@@ -492,7 +492,7 @@ const ChangesSection = (props: ChangesSectionProps) => {
  </Text>
  ) : (
  <Layout.Horizontal>
- <Container padding={{ left: 'medium' }}>
+ <Container padding={{ left: 'large' }}>
  <img alt="emptyStatus" width={16} height={16} src={emptyStatus} />
  </Container>
 

diff --git a/web/src/pages/PullRequest/Conversation/PullRequestOverviewPanel/sections/CommentsSection.tsx b/web/src/pages/PullRequest/Conversation/PullRequestOverviewPanel/sections/CommentsSection.tsx
@@ -71,7 +71,9 @@ const CommentsSection = (props: MergeSectionProps) => {
  label: getString('unrsolvedComment'),
  value: PRCommentFilterType.UNRESOLVED_COMMENTS
  })
- document.querySelectorAll('.bp3-input[value="Active"]')[0].scrollIntoView({ behavior: 'smooth' })
+ setTimeout(() => {
+ document.querySelectorAll('.bp3-input[value="Active"]')[0]?.scrollIntoView({ behavior: 'smooth' })
+ }, 0)
  }}
  />
  ) : null}