fix: [code-1991]: fix check icon and alignment (#2112)

harness · Jun 14, 2024 · 263e864 · 263e864
1 parent 6645c27
commit 263e864
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 10 deletions.
diff --git a/web/package.json b/web/package.json
@@ -47,7 +47,7 @@
  "@codemirror/state": "^6.2.0",
  "@codemirror/view": "^6.9.6",
  "@harnessio/design-system": "^2.1.1",
- "@harnessio/icons": "^2.1.0",
+ "@harnessio/icons": "^2.1.3",
  "@harnessio/uicore": "^4.1.2",
  "@types/dompurify": "^3.0.2",
  "@types/react-monaco-editor": "^0.16.0",

diff --git a/...es/PullRequest/Conversation/PullRequestOverviewPanel/PullRequestOverviewPanel.module.scss b/...es/PullRequest/Conversation/PullRequestOverviewPanel/PullRequestOverviewPanel.module.scss
@@ -189,7 +189,7 @@
 }
 
 .paddingWithOutReq {
- padding-right: 4.55rem !important;
+ padding-right: 4rem !important;
 }
 
 .changeContainerPadding {
@@ -204,7 +204,7 @@
 
 .gridContainer {
  display: grid !important;
- grid-template-columns: 1fr 0.75fr !important;
+ grid-template-columns: 1fr 1fr !important;
  position: relative !important;
 }
 
@@ -218,11 +218,13 @@
 .details {
  grid-column: 1 !important;
  padding-right: var(--spacing-small) !important;
+ text-align: left;
 }
 
 .required {
  margin-left: var(--spacing-small) !important;
  grid-column: 2 !important;
+ text-align: right !important;
 }
 
 /* Pseudo-elements for placeholders to maintain grid structure */

diff --git a/web/src/pages/PullRequest/PullRequest.tsx b/web/src/pages/PullRequest/PullRequest.tsx
@@ -218,8 +218,8 @@ export default function PullRequest() {
  id: PullRequestSection.CHECKS,
  title: (
  <TabTitleWithCount
- icon="main-search"
- iconSize={14}
+ icon={CodeIcon.CheckIcon}
+ iconSize={16}
  title={getString('checks')}
  countElement={
  pullReqChecksDecision?.overallStatus ? (

diff --git a/web/src/utils/GitUtils.ts b/web/src/utils/GitUtils.ts
@@ -250,7 +250,8 @@ export const CodeIcon = {
  InputSearch: 'search' as IconName,
  Chat: 'code-chat' as IconName,
  Checks: 'main-tick' as IconName,
- ChecksSuccess: 'success-tick' as IconName
+ ChecksSuccess: 'success-tick' as IconName,
+ CheckIcon: 'code-checks' as IconName
 }
 
 export const normalizeGitRef = (gitRef: string | undefined) => {

diff --git a/web/yarn.lock b/web/yarn.lock
@@ -1649,10 +1649,10 @@
  resolved "https://registry.npmjs.org/@harnessio/design-system/-/design-system-2.1.1.tgz#2da3036602ed9b9446d8139c72009e6dc1e25642"
  integrity sha512-ZwAGM1srOZ49/6YkwyjkczUv4v91CN0rCecRYnV3/g+xdSV5ycrUvkJjl9nHub6jw2eCGC0GdyNgAtAJnLmGfQ==
 
-"@harnessio/icons@^2.1.0":
- version "2.1.1"
- resolved "https://registry.npmjs.org/@harnessio/icons/-/icons-2.1.1.tgz#1cf4fb4ab5f83dd2389ab6669499dfd6ba8c6b7d"
- integrity sha512-arHZHsqKByvwey9h98HTXQBFrtY+zpTnbGHR5BNqfqg5bSbGJ0mX/2FA0kJpKjxNvywX3K8gqJtZIAyYxpIYyg==
+"@harnessio/icons@^2.1.3":
+ version "2.1.3"
+ resolved "https://registry.yarnpkg.com/@harnessio/icons/-/icons-2.1.3.tgz#abe777ff94491dd1647693fc18e74f956c42fd52"
+ integrity sha512-hlYwjlS8sv46SvXyydnykNu0ZM89+xyGp3MAuOfdKLgxOn1wMMu/88VwP7tPhHmCRhkGhn7xAPY/JLkYT24pgg==
 
 "@harnessio/uicore@^4.1.2":
  version "4.1.2"