Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add topic strengths #29

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Add topic strengths #29

merged 3 commits into from
Mar 14, 2024

Conversation

woodthom2
Copy link
Contributor

Description

Add the topic strengths to the return values, so we know how well the match is working.

Fixes App #13

harmonydata/app#13

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Testing

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • test_match_mhc.py - new unit test
  • Have you ever felt annoyed by criticism of your drinking - should not throw up a match from MHC that is unrelated to the topic.

Test Configuration

  • Library version: 0.5.2
  • OS: Ubuntu
  • Toolchain: Python 3.11

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@woodthom2 woodthom2 merged commit 534ccde into main Mar 14, 2024
1 check passed
@woodthom2 woodthom2 deleted the add_topic_strengths branch March 14, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant