Fix MetricGuage styling bug #174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The circle arc wasn't completly aligned to the center, it was a bit on top of the Y axis, so I fixed it
|
Hey @eylonshm, sorry for the delay. I've never had the metric gauges look like this, would you be able to let me know what browser you're using?
I'm mindful about introducing regressions if we change the styling |
|
@harlan-zw Using Safari, maybe it's about that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The circle arc wasn't completely aligned to the center, it was a bit on top of the Y axis, so I fixed it.
Additionally, there was a problem with the calculation (for example, 100% wasn't a perfect circle), so I fixed its function as well.
Looks like everything is working as expected now.
Linked Issues
Couldn't find a related issue so I just created a new one (173), If there's already related issue, please approve the commit and delete both the old one, and the new one I've created.