UniCache feature #119
Merged
UniCache feature #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er fixes for CI Increase wait_timeout and remove check for node 1 as follower increase timeouts and check leader from other node Add logging Log message of peer not found and NotAccepted. Remove late reply logging in BLE Fix comparison bug in check_valid_ballot() send preparereq to all peers upon timeout in recovery mode Replace confusing self.leader with function that reads from the promise. Move forward proposal and stopsign to mod.
haraldng
force-pushed
the
unicache_macro
branch
from
443f618
to
4b52854
Compare
haraldng
force-pushed
the
unicache_macro
branch
from
189f88e
to
3c2163a
Compare
Update test.toml Update utils.rs
haraldng
force-pushed
the
unicache_macro
branch
from
3c2163a
to
f2cb9c5
Compare
kevin-harrison
suggested changes
Oct 16, 2023
There was a problem hiding this comment.
omnipaxos/omnipaxos/tests/utils.rs
Line 80 in 0903d85
Should rename "resend_message_timeout_ms" instead.
…trying to encode in UniCache
Revert "Try CI with high timeouts" This reverts commit f2cb9c5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked, before submitting a new PR.
./check.shwith no errorsIssues
Fix #63 , fix #116
Other Changes
unicachetoomni_paxosthat introduces theUniCachetraits andAcceptEncodedmessage and related logic in SequencePaxos.derive(Entry)macro by using the#[snapshot()]attribute, instead of having to manually implement Snapshot forEntryderive(UniCacheEntry)macro.unicachefeature to test UniCache.omnipaxos/test_all_features.shcheck.shand PR template.accept_stopsigninstead of setting it directly via InternStorage