Integration test #111
Merged
Integration test #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haraldng
requested changes
Jun 29, 2023
There was a problem hiding this comment.
- Please update the structure of the integration test code so that we use one function per code example in the docs. And each function should have a comment with a link to the exact file and section that it corresponds to (see example in my comment)
- rename
integration_testtodocs_integration_test - Also remove the binary files that got pushed.
omnipaxos/tests/config/storage/node1/00000000000000000000.index
Outdated
Show resolved
Hide resolved
…xamples separated into different function
|
Finished code structure change. |
haraldng
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked, before submitting a new PR.
./check.shwith no errorsIssues
This PR added an integration test in the tests of OmniPaxos library.
Breaking Changes