Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace inconsistent timer in sync_test with decided futures. #110

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

kevin-harrison
Copy link
Contributor

Please make sure these boxes are checked, before submitting a new PR.

  • You ran the local CI checker with ./check.sh with no errors
  • You reference which issue is being closed in the PR text (if applicable)
  • You updated the OmniPaxos book (if applicable)

Issues

Before sync_test used a timer to wait for the follower to receive an AccSync and decide the new entries. If this process took too long the test could fail. Instead its better to use decided futures to determine that the follower received the new entries.

@haraldng haraldng merged commit 129c637 into haraldng:master Jun 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants