Change default host to be IPv6-friendly #4357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanongil
reviewed
Jun 13, 2022
devinivy
commented
Jun 13, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes hapi's default host of
0.0.0.0to use node's IPv6-friendly default host of::or0.0.0.0, depending on whether the machine supports IPv6.Under node v18 the drawbacks of the current default are emphasized, since DNS resolution in node has changed (nodejs/node#39987) allowing
localhostto resolve to the IPv6 address::1— since0.0.0.0was pinned to IPv4, a request tolocalhostfrom node would not be able to connect to a default hapi server.