Session config

[rpassas]

Summary

Original thread here.
Allowing configurable session expiration by initializing a ValidationService in the wrapper with:

• configurable sessionCacheDuration (60 minutes by default)
• ability to setExpirationAfterAccess (when true, accessing sessions will reset the expiration time)

The required changes to core are reflected here.

[dotasek]

This block is repeated:

        sessionCache = SessionCache(sessionCacheDuration, TimeUnit.MINUTES);
        sessionCache.setExpirationAfterAccess(true);
        validationService = ValidationService(sessionCache);

I think it would be better to encapsulate this into a function that returns a ValidationService and keeps sessionCache and sessionCacheDuration only in the scope of that function. I can't see a reason to keep references to those instances.

fun createValidationServiceInstance() : ValidationService {
   val sessionCacheDuration = System.getenv("SESSION_CACHE_DURATION")?.toLong() ?: SESSION_DEFAULT_DURATION;
   val sessionCache = SessionCache(sessionCacheDuration, TimeUnit.MINUTES);
   sessionCache.setExpirationAfterAccess(true);
   return ValidationService(sessionCache);
}

[dotasek]

@rpassas this looks good to me, thank you! I will release this after core gets a new release.