Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options Page Show Times Description duplicated with Extensible Binding Warnings #102

Closed
Hankych opened this issue Oct 20, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Hankych
Copy link
Collaborator

Hankych commented Oct 20, 2022

Update the description of Show Times (showTimes), right now it has the same description as Extensible Binding Warnings.

@dotasek dotasek added the bug Something isn't working label Oct 21, 2022
@dotasek
Copy link
Collaborator

dotasek commented Oct 21, 2022

From the documentation, it looks like both the showTimes and the description are incorrect.

https://confluence.hl7.org/pages/viewpage.action?pageId=35718580#UsingtheFHIRValidator-ShowValidatorInternalTimes

The following is how it should appear:

Show Times (-show-times)

When selected the validator will produce a line in the output summarizing how long some internal processes took.

@dotasek dotasek assigned Hankych and unassigned dotasek Oct 21, 2022
Hankych added a commit that referenced this issue Oct 25, 2022
patrick-werner added a commit that referenced this issue Oct 26, 2022
dotasek added a commit that referenced this issue Oct 31, 2022
* Just some examples of polyglot at work

* Test changes for internationalizaton

* Internationalization - replaced all plain string occurrences on the website with polyglot phrases

* Delete unnecessary comments and tests

* Delete localization folder

* Completed suggested changes for PR - Polyglot Phrases Implementation

* Fix HeaderTabButton onSelected

* Added requested changes by David

* For David to check why props are not recognized under LanguageSelect.kt

* Added changes for detecting browser's default language

* Implements issues #99  #102

* Allowed locale to be set in UI through language option widget

* Deleted extra comma

* Added David's requested changes

* Update polyglot keys under de_DE.json

* Refactored code

* Fixed bug with browser not defaulting to English if no other preferred languages are available

* Updated language option widget position

Co-authored-by: dotasek <[email protected]>
Co-authored-by: Hank Yang <[email protected]>
dotasek added a commit that referenced this issue Nov 2, 2022
* Just some examples of polyglot at work

* Test changes for internationalizaton

* Internationalization - replaced all plain string occurrences on the website with polyglot phrases

* Delete unnecessary comments and tests

* Delete localization folder

* Completed suggested changes for PR - Polyglot Phrases Implementation

* Fix HeaderTabButton onSelected

* Added requested changes by David

* For David to check why props are not recognized under LanguageSelect.kt

* Added changes for detecting browser's default language

* Implements issues #99  #102

* Allowed locale to be set in UI through language option widget

* Deleted extra comma

* Added David's requested changes

* Update polyglot keys under de_DE.json

* Refactored code

* Fixed bug with browser not defaulting to English if no other preferred languages are available

* Updated language option widget position

* Implemented polyglot implementation for selected IGs

* Cleaned up code

* Minor refactor

Co-authored-by: dotasek <[email protected]>
Co-authored-by: Hank Yang <[email protected]>
Co-authored-by: dotasek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants