Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase string value storage length to accomodate larger contains searches #6037

Conversation

tadgh
Copy link
Collaborator

@tadgh tadgh commented Jun 21, 2024

  • increase length from 200 -> 768
  • test
  • Changelog
  • Migration

Closes #6036

@tadgh tadgh requested a review from a team as a code owner June 21, 2024 03:07
Copy link

Formatting check succeeded!

@tadgh
Copy link
Collaborator Author

tadgh commented Jun 21, 2024

Closing this for now as it will not solve the actual use case issue.

@tadgh tadgh closed this Jun 21, 2024
@tadgh tadgh reopened this Jul 5, 2024
@tadgh tadgh enabled auto-merge (squash) July 9, 2024 02:32
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.52%. Comparing base (497b9f2) to head (bab2823).
Report is 130 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6037      +/-   ##
============================================
+ Coverage     83.39%   83.52%   +0.12%     
- Complexity    26927    27410     +483     
============================================
  Files          1681     1706      +25     
  Lines        103965   106137    +2172     
  Branches      13189    13395     +206     
============================================
+ Hits          86702    88646    +1944     
- Misses        11613    11758     +145     
- Partials       5650     5733      +83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tadgh tadgh merged commit 3ffb695 into master Jul 9, 2024
66 checks passed
@tadgh tadgh deleted the 6036-increase-string-value-storage-length-to-accomodate-larger-contains-searches branch July 9, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

increase string value storage length to accomodate larger contains searches.
3 participants