Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve search param extraction flexibility #6030

Merged
merged 12 commits into from
Jun 26, 2024

Conversation

jmarchionatto
Copy link
Collaborator

What was done:

  1. added myExtractResourceLevelParams property to allow extraction of Resource-level search param values
  2. extracted some code to be reused to an util class
  3. Allowed test to specify a Patient provider to RestServerR4Helper

Copy link

Formatting check succeeded!

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.49%. Comparing base (497b9f2) to head (01fda4c).
Report is 112 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6030      +/-   ##
============================================
+ Coverage     83.39%   83.49%   +0.10%     
- Complexity    26927    27347     +420     
============================================
  Files          1681     1703      +22     
  Lines        103965   105906    +1941     
  Branches      13189    13365     +176     
============================================
+ Hits          86702    88430    +1728     
- Misses        11613    11760     +147     
- Partials       5650     5716      +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dotasek dotasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test for the myExtractResourceLevelParams looks good. Is this change attached to a feature, or something else that needs to be put in the changelog, or are these just quality of life improvements.

@jmarchionatto jmarchionatto merged commit 0c642b6 into master Jun 26, 2024
66 checks passed
@jmarchionatto jmarchionatto deleted the jm-improve-search-param-extraction-flexibility branch June 26, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants