Search Param Matcher Performance Improvement #5999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melihaydogd
force-pushed
the
feature/param-matcher-performance-improvement
branch
from
02629d8
to
7946ff1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5999 +/- ##
============================================
+ Coverage 83.39% 83.43% +0.03%
- Complexity 26927 27228 +301
============================================
Files 1681 1695 +14
Lines 103965 105333 +1368
Branches 13189 13317 +128
============================================
+ Hits 86702 87880 +1178
- Misses 11613 11747 +134
- Partials 5650 5706 +56 ☔ View full report in Codecov by Sentry. |
jamesagnew
added a commit
that referenced
this pull request
Jun 17, 2024
* filter function added * spotless * Credit for #5999 --------- Co-authored-by: Melih Aydogdu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extractIndexedSearchParamsfunction usesISearchParamExtractor.ALL_PARAMSby default. This tries to extract all possible values from a resource then tries to match the resource. By adding thegetFilterfunction, we can extract only the values that is in search parameter map. I saw that this had a good impact on the performance of search param matcher.