improve validation for R4 backport subscriptions in SubscriptionValidatingInterceptor #5973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eptorTest tests also there are Msg.code FIXMEs
|
Formatting check succeeded! |
jmarchionatto
approved these changes
May 29, 2024
.../java/ca/uhn/fhir/jpa/subscription/submit/interceptor/SubscriptionValidatingInterceptor.java
Show resolved
Hide resolved
...a/ca/uhn/fhir/jpa/subscription/submit/interceptor/SubscriptionValidatingInterceptorTest.java
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5973 +/- ##
============================================
+ Coverage 83.39% 83.47% +0.07%
- Complexity 26927 27122 +195
============================================
Files 1681 1692 +11
Lines 103965 104655 +690
Branches 13189 13254 +65
============================================
+ Hits 86702 87361 +659
- Misses 11613 11631 +18
- Partials 5650 5663 +13 ☔ View full report in Codecov by Sentry. |
tadgh
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eptorTest tests
also there are Msg.code FIXMEs