added batch job related attributes to OpenTelemetry span #5972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Formatting check succeeded! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5972 +/- ##
============================================
+ Coverage 83.39% 83.42% +0.03%
- Complexity 26927 27117 +190
============================================
Files 1681 1694 +13
Lines 103965 104733 +768
Branches 13189 13275 +86
============================================
+ Hits 86702 87376 +674
- Misses 11613 11658 +45
- Partials 5650 5699 +49 ☔ View full report in Codecov by Sentry. |
mrdnctrk
force-pushed
the
emre-batch-job-span
branch
2 times, most recently
from
ec7bbe7
to
301525b
Compare
mrdnctrk
requested review from
michaelabuckley,
jamesagnew and
tadgh
as code owners
mrdnctrk
force-pushed
the
emre-batch-job-span
branch
2 times, most recently
from
b1a0d89
to
806703c
Compare
mrdnctrk
commented
Jun 4, 2024
hapi-fhir-base/src/main/java/ca/uhn/fhir/interceptor/executor/BaseInterceptorService.java
Show resolved
Hide resolved
volodymyr-korzh
approved these changes
Jun 5, 2024
.../main/resources/ca/uhn/hapi/fhir/changelog/7_4_0/5980-opentelemetry-spans-for-batchjobs.yaml
Outdated
Show resolved
Hide resolved
mrdnctrk
force-pushed
the
emre-batch-job-span
branch
2 times, most recently
from
e502f39
to
589bf5a
Compare
mrdnctrk
force-pushed
the
emre-batch-job-span
branch
from
589bf5a
to
7613fc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces OpenTelemetry spans named
hapifhir.batch_job.executecreated by the batch job worker threads.These spans have the following span attributes related to the batch job:
hapifhir.batch_job.definition_id: The name of the job, such asBULK_EXPORT,REINDEX.hapifhir.batch_job.definition_version: The job definition version.hapifhir.batch_job.instance_id: The job id.hapifhir.batch_job.step_id: The name of the step being executed.hapifhir.batch_job.chunk_id: The id of the work chunk being processed. This is not applicable to reduction steps.close #5980