Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the use of Accept-Charset when using the HAPI client #5961

Merged

Conversation

jkiddo
Copy link
Contributor

@jkiddo jkiddo commented May 24, 2024

No description provided.

@jkiddo jkiddo marked this pull request as ready for review May 24, 2024 14:13
Copy link
Collaborator

@jamesagnew jamesagnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@jamesagnew
Copy link
Collaborator

FYI the spotless check failure is a false negative, it doesn't work on forks for some reason. Assuming all tests pass, I'll merge this asap.

@jkiddo
Copy link
Contributor Author

jkiddo commented May 24, 2024

I dont understand the error in the docs compilation

@jamesagnew
Copy link
Collaborator

@jkiddo There are 3 quote marks in the title attribute for the changelog, which isn't valid in YAML.

@jkiddo
Copy link
Contributor Author

jkiddo commented May 24, 2024

🤦

@jkiddo
Copy link
Contributor Author

jkiddo commented May 24, 2024

Fixed

@jamesagnew jamesagnew merged commit 848fee0 into hapifhir:master May 24, 2024
59 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants