Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix queries with chained sort with Lucene by checking supported SortSpecs #5958

Merged
merged 4 commits into from
May 24, 2024
Merged

Fix queries with chained sort with Lucene by checking supported SortSpecs #5958

merged 4 commits into from
May 24, 2024

Conversation

lukedegruchy
Copy link
Collaborator

@lukedegruchy lukedegruchy commented May 23, 2024 •
edited
Loading

  • Introspect all SortSpec chains to ensure all are supported and trigger non-hibernate search if even a single one is unsupported
  • Fail immediately if a user attempts to combine a chained sort with a _text search
  • Introduce a new algorithm to cycle through all chains in the SearchParameter SortSpec
  • Fail immediately if a SortSpec is unsupported in Hibernate search instead of ignoring it
  • New tests

Closes: #5960

@github-actions GitHub Actions
Copy link

Formatting check succeeded!

@lukedegruchy lukedegruchy marked this pull request as ready for review May 24, 2024 13:50
@codecov Codecov
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.45%. Comparing base (497b9f2) to head (c64cf02).
Report is 69 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #5958      +/-   ##
============================================
+ Coverage     83.39%   83.45%   +0.05%     
- Complexity    26927    27105     +178     
============================================
  Files          1681     1692      +11     
  Lines        103965   104624     +659     
  Branches      13189    13251      +62     
============================================
+ Hits          86702    87310     +608     
- Misses        11613    11645      +32     
- Partials       5650     5669      +19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukedegruchy lukedegruchy changed the title First commit with very rough solution. Fix queries with chained sort with Lucene by checking supported SortSpecs May 24, 2024
@lukedegruchy lukedegruchy merged commit 7f91f1f into master May 24, 2024
65 of 66 checks passed
@lukedegruchy lukedegruchy deleted the ld-20240523-lucene-chain-sort-silently-not-working branch May 24, 2024 18:30
longma1 pushed a commit that referenced this pull request May 29, 2024
@lukedegruchy
Fix queries with chained sort with Lucene by checking supported SortS…
ac4aa1e 
…pecs (#5958)

* First commit with very rough solution.

* Solidify solutions for both requirements.  Add new tests.  Enhance others.

* Spotless.

* Add new chained sort spec algorithm.  Add new Msg.codes.  Finalize tests.  Update docs.  Add changelog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesagnew jamesagnew jamesagnew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chained sort with Lucene indexing fails
2 participants
@lukedegruchy @jamesagnew