Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include profile URL in generated IPS #5938

Merged
merged 3 commits into from
May 16, 2024

Conversation

jamesagnew
Copy link
Collaborator

When we generate an IPS bundle, the bundle should be tagged with the appropriate profile URL.

Copy link

Formatting check succeeded!

Copy link
Collaborator

@jmarchionatto jmarchionatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but wouldn't interface change merit corresponding documentation update?

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.43%. Comparing base (497b9f2) to head (ac5c2c6).
Report is 62 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5938      +/-   ##
============================================
+ Coverage     83.39%   83.43%   +0.04%     
- Complexity    26927    27084     +157     
============================================
  Files          1681     1692      +11     
  Lines        103965   104546     +581     
  Branches      13189    13234      +45     
============================================
+ Hits          86702    87229     +527     
- Misses        11613    11654      +41     
- Partials       5650     5663      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamesagnew jamesagnew merged commit 14c364d into master May 16, 2024
65 of 66 checks passed
@jamesagnew jamesagnew deleted the ja_20240515_include_profile_in_ips branch May 16, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants