Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for returning subproperties for RemoteTerminologyService lookup #5936

Conversation

codeforgreen
Copy link
Collaborator

@codeforgreen codeforgreen commented May 14, 2024

#5935

Please note that R5 is not yet implemented for RemoteTerminologyService just yet. That is a separate feature.

Copy link

github-actions bot commented May 14, 2024

Formatting check succeeded!

@codeforgreen codeforgreen changed the title Add support for returning subproperties in the RemoteTerminologyService Add support for returning subproperties for RemoteTerminologyService lookup May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.44%. Comparing base (497b9f2) to head (7100475).
Report is 65 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5936      +/-   ##
============================================
+ Coverage     83.39%   83.44%   +0.05%     
- Complexity    26927    27089     +162     
============================================
  Files          1681     1692      +11     
  Lines        103965   104569     +604     
  Branches      13189    13242      +53     
============================================
+ Hits          86702    87260     +558     
- Misses        11613    11640      +27     
- Partials       5650     5669      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jmarchionatto jmarchionatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need you to walk me through some of the test changes.

@codeforgreen codeforgreen merged commit bff59b6 into master May 16, 2024
65 of 66 checks passed
@codeforgreen codeforgreen deleted the mm-20240514-remote-terminology-lookup-can-return-subproperty branch May 16, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants