-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combo SearchParameter improvements #5885
Conversation
Formatting check succeeded! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5885 +/- ##
============================================
+ Coverage 83.39% 83.50% +0.11%
- Complexity 26927 27387 +460
============================================
Files 1681 1704 +23
Lines 103965 106041 +2076
Branches 13189 13391 +202
============================================
+ Hits 86702 88551 +1849
- Misses 11613 11763 +150
- Partials 5650 5727 +77 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending questions and comments
This PR cleans up the way that combo SPs are indexed and searched for: