Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combo SearchParameter improvements #5885

Merged
merged 39 commits into from
Jun 27, 2024
Merged

Conversation

jamesagnew
Copy link
Collaborator

@jamesagnew jamesagnew commented Apr 29, 2024

This PR cleans up the way that combo SPs are indexed and searched for:

  • The non-unique combo param index table has a hash column that was previously not used. This is now indexed and searched against, and the old column will be dropped in a future release.
  • The unique combo param index table did not have a hash column, so one has been added. In a future release it will be indexed and searched against, for now it is only being populated as the first step in a multi-release cleanup.
  • Indexing for the two kinds of combo params has been harmonized, previously these were indexed in completely separate parts of the indexing pipeline. This does not affect functionality, but should make maintenance much easier.
  • A number of tests have been added for non-unique combo params, as I found that this feature was not well unit tested
  • Logic for Combo params has been added to the prefetch module that speeds up reindex and FHIR transaction operations on servers where they are used

@jamesagnew jamesagnew requested a review from a team as a code owner April 29, 2024 20:59
Copy link

github-actions bot commented Apr 29, 2024

Formatting check succeeded!

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.50%. Comparing base (497b9f2) to head (90218ec).
Report is 114 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5885      +/-   ##
============================================
+ Coverage     83.39%   83.50%   +0.11%     
- Complexity    26927    27387     +460     
============================================
  Files          1681     1704      +23     
  Lines        103965   106041    +2076     
  Branches      13189    13391     +202     
============================================
+ Hits          86702    88551    +1849     
- Misses        11613    11763     +150     
- Partials       5650     5727      +77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tadgh tadgh added the Work In Progress Work does not need to be reviewed yet, and shouldnt be considered for staleness. label Jun 12, 2024
Copy link
Collaborator

@tadgh tadgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending questions and comments

@jamesagnew jamesagnew merged commit 7224245 into master Jun 27, 2024
66 checks passed
@jamesagnew jamesagnew deleted the ja_20240418_support_combo_refs branch June 27, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Work In Progress Work does not need to be reviewed yet, and shouldnt be considered for staleness.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants