Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve 5758-completion-handler-for-reduction-steps-are-not-called-with-the-up-to-date-job-instance-status #5759

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Resolve 5758-completion-handler-for-reduction-steps-are-not-called-with-the-up-to-date-job-instance-status #5759

merged 3 commits into from
Mar 6, 2024

Conversation

TynerGjs
Copy link
Contributor

@TynerGjs TynerGjs commented Mar 5, 2024

What was done:

  • updated job status after run is called
  • added check to corresponding tests
  • added changelog

@TynerGjs TynerGjs linked an issue Mar 5, 2024 that may be closed by this pull request
Completion handler for Reduction Steps are not called with the up-to-date job instance status #5758
Closed
@TynerGjs TynerGjs changed the title Resolve 5758 Resolve 5758-completion-handler-for-reduction-steps-are-not-called-with-the-up-to-date-job-instance-status Mar 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

Formatting check succeeded!

@codecov Codecov
Copy link

codecov bot commented Mar 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.38%. Comparing base (497b9f2) to head (9f73517).
Report is 6 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #5759      +/-   ##
============================================
- Coverage     83.39%   83.38%   -0.01%     
  Complexity    26927    26927              
============================================
  Files          1681     1681              
  Lines        103965   103995      +30     
  Branches      13189    13192       +3     
============================================
+ Hits          86702    86717      +15     
- Misses        11613    11622       +9     
- Partials       5650     5656       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TipzCM TipzCM merged commit df047a9 into master Mar 6, 2024
65 of 66 checks passed
@TipzCM TipzCM deleted the 5758-completion-handler-for-reduction-steps-are-not-called-with-the-up-to-date-job-instance-status branch March 6, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TipzCM TipzCM TipzCM approved these changes

@michaelabuckley michaelabuckley Awaiting requested review from michaelabuckley michaelabuckley is a code owner

@jamesagnew jamesagnew Awaiting requested review from jamesagnew jamesagnew is a code owner

@tadgh tadgh Awaiting requested review from tadgh tadgh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Completion handler for Reduction Steps are not called with the up-to-date job instance status
2 participants
@TynerGjs @TipzCM