-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and fix functionality dealing with ReadPartitionIdRequestDetails #5691
Refactor and fix functionality dealing with ReadPartitionIdRequestDetails #5691
Conversation
…performing FHIR search with non-chained reference
…ined-reference-search-ignores-resource-type-in-reference
Formatting check succeeded! |
…rtition-id-details-refactoring-and-fixing
…rtition-id-details-refactoring-and-fixing
…rtition-id-details-refactoring-and-fixing
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/search/builder/QueryStack.java
Outdated
Show resolved
Hide resolved
...paserver-searchparam/src/main/java/ca/uhn/fhir/jpa/partition/IRequestPartitionHelperSvc.java
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5691 +/- ##
============================================
+ Coverage 81.32% 83.38% +2.05%
- Complexity 23650 26886 +3236
============================================
Files 1425 1679 +254
Lines 86399 103799 +17400
Branches 11677 13149 +1472
============================================
+ Hits 70265 86554 +16289
- Misses 10947 11612 +665
- Partials 5187 5633 +446 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems careful and safe.
Made a minor suggestion about test name.
I'm not sure about replacing the parameter object pattern with overloaded methods, but at least they are all non-null. I think this would have been cleaner with overloads or builders on the underlying ReadPartitionIdRequestDetails instead of the service layer. It shows up in all the mock changes for the new methods names.
closes #5694
Summary of changes:
IRequestPartitionHelperSvc
which involve computing partitionId for read requests (including search, history, mdm related operations and system operations like bulk import/export, reindex). Do not allow this parameter to be passed as null.IRequestPartitionHelperSvc
such that caller no longer needs to pass null arguments.