Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPS API Refactor #5682

Merged
merged 23 commits into from
Feb 11, 2024
Merged

IPS API Refactor #5682

merged 23 commits into from
Feb 11, 2024

Conversation

jamesagnew
Copy link
Collaborator

This is a refactor of the IPS generation API in order to make it more flexible.

  • Sourcing data from non-JPA sources is now supported
  • Multiple generation strategies can be used

Copy link

github-actions bot commented Feb 6, 2024

Formatting check succeeded!

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2f5ffe7) 81.32% compared to head (2a49124) 83.37%.
Report is 442 commits behind head on master.

❗ Current head 2a49124 differs from pull request most recent head a2ae67e. Consider uploading reports for the commit a2ae67e to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5682      +/-   ##
============================================
+ Coverage     81.32%   83.37%   +2.05%     
- Complexity    23650    26869    +3219     
============================================
  Files          1425     1679     +254     
  Lines         86399   103748   +17349     
  Branches      11677    13150    +1473     
============================================
+ Hits          70265    86503   +16238     
- Misses        10947    11611     +664     
- Partials       5187     5634     +447     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jmarchionatto jmarchionatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions and comments added

@jamesagnew jamesagnew merged commit 12eb2d6 into master Feb 11, 2024
60 of 63 checks passed
@jamesagnew jamesagnew deleted the ja_20240111_ips_allow_external_fetch branch February 11, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants