Fix fhirpath expression evaluation with _fhirpath parameter when resolve() references resources within a Bundle #5565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lve() references resources within a Bundle
|
Formatting check succeeded! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5565 +/- ##
============================================
+ Coverage 81.32% 83.32% +1.99%
- Complexity 23650 26661 +3011
============================================
Files 1425 1646 +221
Lines 86399 103136 +16737
Branches 11677 13119 +1442
============================================
+ Hits 70265 85937 +15672
- Misses 10947 11560 +613
- Partials 5187 5639 +452 ☔ View full report in Codecov by Sentry. |
jmarchionatto
approved these changes
Dec 21, 2023
...es-r4/src/test/java/ca/uhn/fhir/rest/server/interceptor/FhirPathFilterInterceptorR4Test.java
Outdated
Show resolved
Hide resolved
...-searchparam/src/main/java/ca/uhn/fhir/jpa/searchparam/extractor/SearchParamExtractorR4.java
Outdated
Show resolved
Hide resolved
added 3 commits
January 8, 2024 15:43
…h-expressions-with-resolve-does-not-work-within-bundle
jmarchionatto
deleted the
mm-20231220-fhirpath-expressions-with-resolve-does-not-work-within-bundle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5564
General idea with the fix.
I reused some logic that was previously in method
resolveResourceInBundleWithPlaceholderIdwhich resolved references forSearchParameterevaluation and moved it to the BundleUtil class. I then reused in the the interceptor for_fhirpathsearch parameter.