Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the desired Propagation in a tx template #5516

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

michaelabuckley
Copy link
Contributor

HapiTransactionService is designed for sub-classing, but has no getters for important properties. This exposes them.

Copy link

Formatting check succeeded!

Copy link
Collaborator

@nathandoef nathandoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice test!

@michaelabuckley michaelabuckley marked this pull request as draft November 30, 2023 19:18
@michaelabuckley michaelabuckley marked this pull request as ready for review November 30, 2023 19:28
@michaelabuckley michaelabuckley enabled auto-merge (squash) November 30, 2023 19:29
@michaelabuckley michaelabuckley enabled auto-merge (squash) November 30, 2023 19:57
# Conflicts:
#	hapi-deployable-pom/pom.xml
#	hapi-fhir-android/pom.xml
#	hapi-fhir-base/pom.xml
#	hapi-fhir-bom/pom.xml
#	hapi-fhir-checkstyle/pom.xml
#	hapi-fhir-cli/hapi-fhir-cli-api/pom.xml
#	hapi-fhir-cli/hapi-fhir-cli-app/pom.xml
#	hapi-fhir-cli/pom.xml
#	hapi-fhir-client-okhttp/pom.xml
#	hapi-fhir-client/pom.xml
#	hapi-fhir-converter/pom.xml
#	hapi-fhir-dist/pom.xml
#	hapi-fhir-docs/pom.xml
#	hapi-fhir-jacoco/pom.xml
#	hapi-fhir-jaxrsserver-base/pom.xml
#	hapi-fhir-jpa/pom.xml
#	hapi-fhir-jpaserver-base/pom.xml
#	hapi-fhir-jpaserver-elastic-test-utilities/pom.xml
#	hapi-fhir-jpaserver-hfql/pom.xml
#	hapi-fhir-jpaserver-ips/pom.xml
#	hapi-fhir-jpaserver-mdm/pom.xml
#	hapi-fhir-jpaserver-model/pom.xml
#	hapi-fhir-jpaserver-searchparam/pom.xml
#	hapi-fhir-jpaserver-subscription/pom.xml
#	hapi-fhir-jpaserver-test-dstu2/pom.xml
#	hapi-fhir-jpaserver-test-dstu3/pom.xml
#	hapi-fhir-jpaserver-test-r4/pom.xml
#	hapi-fhir-jpaserver-test-r4b/pom.xml
#	hapi-fhir-jpaserver-test-r5/pom.xml
#	hapi-fhir-jpaserver-test-utilities/pom.xml
#	hapi-fhir-jpaserver-uhnfhirtest/pom.xml
#	hapi-fhir-server-cds-hooks/pom.xml
#	hapi-fhir-server-mdm/pom.xml
#	hapi-fhir-server-openapi/pom.xml
#	hapi-fhir-server/pom.xml
#	hapi-fhir-serviceloaders/hapi-fhir-caching-api/pom.xml
#	hapi-fhir-serviceloaders/hapi-fhir-caching-caffeine/pom.xml
#	hapi-fhir-serviceloaders/hapi-fhir-caching-guava/pom.xml
#	hapi-fhir-serviceloaders/hapi-fhir-caching-testing/pom.xml
#	hapi-fhir-serviceloaders/pom.xml
#	hapi-fhir-spring-boot/hapi-fhir-spring-boot-autoconfigure/pom.xml
#	hapi-fhir-spring-boot/hapi-fhir-spring-boot-samples/hapi-fhir-spring-boot-sample-client-apache/pom.xml
#	hapi-fhir-spring-boot/hapi-fhir-spring-boot-samples/hapi-fhir-spring-boot-sample-client-okhttp/pom.xml
#	hapi-fhir-spring-boot/hapi-fhir-spring-boot-samples/hapi-fhir-spring-boot-sample-server-jersey/pom.xml
#	hapi-fhir-spring-boot/hapi-fhir-spring-boot-samples/pom.xml
#	hapi-fhir-spring-boot/hapi-fhir-spring-boot-starter/pom.xml
#	hapi-fhir-spring-boot/pom.xml
#	hapi-fhir-sql-migrate/pom.xml
#	hapi-fhir-storage-batch2-jobs/pom.xml
#	hapi-fhir-storage-batch2-test-utilities/pom.xml
#	hapi-fhir-storage-batch2/pom.xml
#	hapi-fhir-storage-cr/pom.xml
#	hapi-fhir-storage-mdm/pom.xml
#	hapi-fhir-storage-test-utilities/pom.xml
#	hapi-fhir-storage/pom.xml
#	hapi-fhir-structures-dstu2.1/pom.xml
#	hapi-fhir-structures-dstu2/pom.xml
#	hapi-fhir-structures-dstu3/pom.xml
#	hapi-fhir-structures-hl7org-dstu2/pom.xml
#	hapi-fhir-structures-r4/pom.xml
#	hapi-fhir-structures-r4b/pom.xml
#	hapi-fhir-structures-r5/pom.xml
#	hapi-fhir-test-utilities/pom.xml
#	hapi-fhir-testpage-overlay/pom.xml
#	hapi-fhir-validation-resources-dstu2.1/pom.xml
#	hapi-fhir-validation-resources-dstu2/pom.xml
#	hapi-fhir-validation-resources-dstu3/pom.xml
#	hapi-fhir-validation-resources-r4/pom.xml
#	hapi-fhir-validation-resources-r4b/pom.xml
#	hapi-fhir-validation-resources-r5/pom.xml
#	hapi-fhir-validation/pom.xml
#	hapi-tinder-plugin/pom.xml
#	hapi-tinder-test/pom.xml
#	pom.xml
#	tests/hapi-fhir-base-test-jaxrsserver-kotlin/pom.xml
#	tests/hapi-fhir-base-test-mindeps-client/pom.xml
#	tests/hapi-fhir-base-test-mindeps-server/pom.xml
@michaelabuckley michaelabuckley merged commit fab00ca into master Nov 30, 2023
64 checks passed
@michaelabuckley michaelabuckley deleted the mb-hapi-tx-inheritance branch November 30, 2023 21:43
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2f5ffe7) 81.32% compared to head (1dda365) 82.87%.
Report is 368 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5516      +/-   ##
============================================
+ Coverage     81.32%   82.87%   +1.54%     
- Complexity    23650    26610    +2960     
============================================
  Files          1425     1648     +223     
  Lines         86399   103449   +17050     
  Branches      11677    13195    +1518     
============================================
+ Hits          70265    85732   +15467     
- Misses        10947    12080    +1133     
- Partials       5187     5637     +450     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants