feature swap to non javax clinical reasoning #5463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… javax dependencies
|
Formatting check succeeded! |
|
Just when I thought i was done reviewing Jakarta migration PRs 👷🏻 |
|
This PR should remove the need for the custom CQL/CR branches James used previously for Jakarta. All the needed changes should have already been rolled into those projects. |
JPercival
reviewed
Nov 20, 2023
hapi-fhir-storage-cr/src/test/java/ca/uhn/fhir/cr/r4/CrResourceListenerTests.java
Show resolved
Hide resolved
hapi-fhir-storage-cr/src/test/java/ca/uhn/fhir/cr/TestCrConfig.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5463 +/- ##
============================================
+ Coverage 81.32% 82.92% +1.59%
- Complexity 23650 26553 +2903
============================================
Files 1425 1637 +212
Lines 86399 103138 +16739
Branches 11677 13174 +1497
============================================
+ Hits 70265 85524 +15259
- Misses 10947 11987 +1040
- Partials 5187 5627 +440 ☔ View full report in Codecov by Sentry. |
barhodes
approved these changes
Nov 20, 2023
tadgh
approved these changes
Nov 21, 2023
hapi-fhir-storage-cr/src/test/java/ca/uhn/fhir/cr/dstu3/TestCrDstu3Config.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes issue: #5436
updated testing config for new retrieveSettings and terminologySettings
updated measureOperationProvider (r4/Dstu3) with new Parameter
breaking change to evaluate-measure operation