Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove requirement to have 'missing' idxs enabled for patient bulk export #5447

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

XcrigX
Copy link
Contributor

@XcrigX XcrigX commented Nov 10, 2023

TBH, I'm not clear why missing indexes were required for patient bulk export in the first place. So I'm not certain if this PR is "safe". But submitting for review in the hopes it was some old holdover that is no longer necessary.

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2f5ffe7) 81.32% compared to head (639bf75) 82.99%.
Report is 340 commits behind head on master.

❗ Current head 639bf75 differs from pull request most recent head 9b15329. Consider uploading reports for the commit 9b15329 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5447      +/-   ##
============================================
+ Coverage     81.32%   82.99%   +1.66%     
- Complexity    23650    26491    +2841     
============================================
  Files          1425     1630     +205     
  Lines         86399   102758   +16359     
  Branches      11677    13115    +1438     
============================================
+ Hits          70265    85279   +15014     
- Misses        10947    11872     +925     
- Partials       5187     5607     +420     

see 1651 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stmsat
Copy link

stmsat commented Mar 15, 2024

From what I've gathered in a very short and not accurate search, the class JpaBulkExportProcessor was introduced in #3566, and the requirement for IndexMissingFields=ENABLED could possibly be dropped after this PR was merged: #3982

Before that change, maybe not all resources linked to the patient could be exported correctly, or errors were thrown anyway (just guessing).

I obviously don't have the full picture yet. Just stumbled on this issue and wanted to know more about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants