Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #5364 InvalidPathException: Illegal char <:> at index 5: #5365

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bdenton
Copy link
Collaborator

@bdenton bdenton commented Oct 12, 2023

Fixes Issue #5364 so that UrlUtil.getAboveUrlCandidates() produces the same result for all underlying file systems. This fix removes the use of Paths.get() which is dependent on the underlying native FileSystem implementation.

https://hos... at ca.uhn.fhir.util.UrlUtil.getAboveUriCandidates() on
Windows
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2f5ffe7) 81.32% compared to head (41b548c) 82.98%.
Report is 328 commits behind head on master.

❗ Current head 41b548c differs from pull request most recent head 495e1be. Consider uploading reports for the commit 495e1be to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5365      +/-   ##
============================================
+ Coverage     81.32%   82.98%   +1.66%     
- Complexity    23650    26475    +2825     
============================================
  Files          1425     1629     +204     
  Lines         86399   102740   +16341     
  Branches      11677    13114    +1437     
============================================
+ Hits          70265    85263   +14998     
- Misses        10947    11874     +927     
- Partials       5187     5603     +416     

see 1645 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant