Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve 5336 Mdm Link History Would Fail If Provided with Unknown Ids On Postgres #5337

Conversation

TynerGjs
Copy link
Contributor

What was done:

  • Added checks in MdmLinkDaoJpaImpl to make sure no empty IN clauses are sent to database.
  • Implemented tests for the above change.

…are sent to database.

- Implemented tests for the above change.
@github-actions
Copy link

Formatting check succeeded!

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2f5ffe7) 81.32% compared to head (cda020e) 82.82%.
Report is 317 commits behind head on master.

❗ Current head cda020e differs from pull request most recent head 968c104. Consider uploading reports for the commit 968c104 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5337      +/-   ##
============================================
+ Coverage     81.32%   82.82%   +1.50%     
- Complexity    23650    26314    +2664     
============================================
  Files          1425     1613     +188     
  Lines         86399   102265   +15866     
  Branches      11677    13076    +1399     
============================================
+ Hits          70265    84704   +14439     
- Misses        10947    11962    +1015     
- Partials       5187     5599     +412     

see 1627 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jmarchionatto jmarchionatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Approved with a small change request

@lukedegruchy lukedegruchy merged commit c3ff3da into master Sep 27, 2023
64 checks passed
@lukedegruchy lukedegruchy deleted the 5336-mdm-link-history-would-fail-if-provided-with-unknown-ids-on-postgres branch September 27, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mdm Link History Would Fail If Provided with Unknown Ids On Postgres
3 participants