-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding metrics #5301
adding metrics #5301
Conversation
Formatting check succeeded! |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5301 +/- ##
============================================
+ Coverage 81.32% 82.90% +1.57%
- Complexity 23650 26447 +2797
============================================
Files 1425 1629 +204
Lines 86399 102756 +16357
Branches 11677 13101 +1424
============================================
+ Hits 70265 85190 +14925
- Misses 10947 11969 +1022
- Partials 5187 5597 +410 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Some minor stuff.
don't introduce a new tag system if there is already one in use.
Consider quantizing (rounding) the score historgram if score has decimals.
closes #5274