Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding metrics #5301

Merged
merged 21 commits into from
Sep 29, 2023
Merged

adding metrics #5301

merged 21 commits into from
Sep 29, 2023

Conversation

TipzCM
Copy link
Collaborator

@TipzCM TipzCM commented Sep 11, 2023

closes #5274

@TipzCM TipzCM requested review from fil512, tadgh, AD1306 and a team as code owners September 11, 2023 20:01
@github-actions
Copy link

github-actions bot commented Sep 11, 2023

Formatting check succeeded!

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2f5ffe7) 81.32% compared to head (8fe4dee) 82.90%.
Report is 316 commits behind head on master.

❗ Current head 8fe4dee differs from pull request most recent head 04770a1. Consider uploading reports for the commit 04770a1 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5301      +/-   ##
============================================
+ Coverage     81.32%   82.90%   +1.57%     
- Complexity    23650    26447    +2797     
============================================
  Files          1425     1629     +204     
  Lines         86399   102756   +16357     
  Branches      11677    13101    +1424     
============================================
+ Hits          70265    85190   +14925     
- Misses        10947    11969    +1022     
- Partials       5187     5597     +410     

see 1644 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@michaelabuckley michaelabuckley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Some minor stuff.
don't introduce a new tag system if there is already one in use.
Consider quantizing (rounding) the score historgram if score has decimals.

@TipzCM TipzCM merged commit 7e0fa98 into master Sep 29, 2023
65 checks passed
@TipzCM TipzCM deleted the 5274-adding-metrics-to-mdm branch September 29, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MDM requires an ability to request metrics of links in the system
2 participants