Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nickname svc refatoring #5006

Merged
merged 10 commits into from
Jun 22, 2023
Merged

nickname svc refatoring #5006

merged 10 commits into from
Jun 22, 2023

Conversation

TipzCM
Copy link
Collaborator

@TipzCM TipzCM commented Jun 19, 2023

closes #5005

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.89 🎉

Comparison is base (2f5ffe7) 81.32% compared to head (aa990f4) 83.22%.

❗ Current head aa990f4 differs from pull request most recent head b0b1d7a. Consider uploading reports for the commit b0b1d7a to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5006      +/-   ##
============================================
+ Coverage     81.32%   83.22%   +1.89%     
- Complexity    23650    25634    +1984     
============================================
  Files          1425     1561     +136     
  Lines         86399    93515    +7116     
  Branches      11677    12434     +757     
============================================
+ Hits          70265    77825    +7560     
+ Misses        10947    10218     -729     
- Partials       5187     5472     +285     

see 1530 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TipzCM TipzCM merged commit d7bdabb into master Jun 22, 2023
62 of 63 checks passed
@TipzCM TipzCM deleted the 5005-nickname-svc-shared branch June 22, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nickname Svc is not shared/shareable across mdm and persistence and search modules
2 participants