Bundle resources containing over 100 references to the same Organizat…

…ion will fail with HAPI-2207 (#4871)

* Add failing unit test.

* Fix JpaId Long equality comparison to use ! equals() instead of !=, which fails for different instances of the same Long value.

* Add changelog.

hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/6_6_0/4872-bundle-resource-over-100-refs-to-same-org-hapi-2207.yaml

@@ -0,0 +1,5 @@
+---
+type: fix
+issue: 4872
+title: "POSTing a Bundle with over 100 references to the same resource will fail with HAPI-2207 'Multiple resources match'.
+        This has been fixed."

hapi-fhir-jpaserver-test-r4/src/test/java/ca/uhn/fhir/jpa/dao/r4/FhirSystemDaoR4Test.java

@@ -107,6 +107,7 @@
 import java.util.UUID;
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.stream.Collectors;
+import java.util.stream.IntStream;
 
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.Matchers.contains;
@@ -4113,6 +4114,41 @@ public void testTransactionWithInlineMatchUrlMultipleMatches() throws Exception
 
 	}
 
+	@Test
+	public void testOrganizationOver100ReferencesFromBundleNoMultipleResourcesMatchError() throws IOException {
+		myStorageSettings.setAllowInlineMatchUrlReferences(true);
+
+		// The bug involves a invalid Long equality comparison, so we need a generated organization ID much larger than 1.
+		IntStream.range(0, 150).forEach(myint -> {
+			Patient patient = new Patient();
+			patient.addIdentifier().setSystem("https://www.ghh.org/identifiers").setValue("condreftestpatid1");
+			myPatientDao.create(patient, mySrd);
+		});
+
+		final Organization organization = new Organization();
+		organization.addIdentifier().setSystem("https://github.com/synthetichealth/synthea")
+			.setValue("9395b8cb-702c-3c5d-926e-1c3524fd6560");
+		organization.setName("PCP1401");
+		myOrganizationDao.create(organization, mySrd);
+
+		// This bundle needs to have over 100 resources, each referring to the same organization above.
+		// If there are 100 or less, then TransactionProcessor.preFetchConditionalUrls() will work off the same Long instance for the Organization JpaId
+		// and the Long == Long equality comparison will work
+		final InputStream resourceAsStream = getClass().getResourceAsStream("/bundle-refers-to-same-organization.json");
+		assertNotNull(resourceAsStream);
+		final String input = IOUtils.toString(resourceAsStream, StandardCharsets.UTF_8);
+		final Bundle bundle = myFhirContext.newJsonParser().parseResource(Bundle.class, input);
+
+		try {
+			mySystemDao.transaction(mySrd, bundle);
+		} catch (PreconditionFailedException thePreconditionFailedException) {
+			if (thePreconditionFailedException.getMessage().contains(Msg.code(2207))) {
+				fail("This test has failed with HAPI-2207, exactly the condition we aim to prevent");
+			}
+			// else let the Exception bubble up
+		}
+	}
+
 	@Test
 	public void testTransactionWithInlineMatchUrlNoMatches() throws Exception {
 		myStorageSettings.setAllowInlineMatchUrlReferences(true);