Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump core, fix compilation errors #4824

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Conversation

dotasek
Copy link
Contributor

@dotasek dotasek commented May 5, 2023

Bump core version, fix compilation errors for new ValidationResult constructor signatures.

Follows pattern used in kindling updates: HL7/kindling@f765642

@dotasek dotasek requested a review from jamesagnew May 5, 2023 13:36
Match the pattern used by Grahame in this update of kindling: HL7/kindling@f765642
@dotasek dotasek marked this pull request as ready for review May 5, 2023 13:40
@dotasek dotasek removed the request for review from jamesagnew May 5, 2023 14:19
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.81 🎉

Comparison is base (2f5ffe7) 81.32% compared to head (126ddac) 83.14%.

❗ Current head 126ddac differs from pull request most recent head 94fda09. Consider uploading reports for the commit 94fda09 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4824      +/-   ##
============================================
+ Coverage     81.32%   83.14%   +1.81%     
- Complexity    23650    25310    +1660     
============================================
  Files          1425     1542     +117     
  Lines         86399    92332    +5933     
  Branches      11677    12316     +639     
============================================
+ Hits          70265    76768    +6503     
+ Misses        10947    10137     -810     
- Partials       5187     5427     +240     

see 1501 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

barhodes and others added 19 commits May 5, 2023 08:50
* Merge 4821 into master

* Update to PRE3 snapshot
* 4801 - Added new Index on HFJ_RESOURCE table.

* 4801 - Added new migration task for new Index on HFJ_RESOURCE table.

* Update hapi-fhir-jpaserver-model/src/main/java/ca/uhn/fhir/jpa/model/entity/ResourceTable.java

Co-authored-by: michaelabuckley <[email protected]>

* Update hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/migrate/tasks/HapiFhirJpaMigrationTasks.java

Co-authored-by: michaelabuckley <[email protected]>

* Applied review changes.

---------

Co-authored-by: michaelabuckley <[email protected]>
* Test, fix

* Drop constraint, add migration

* Add changelog

* Fix userSelected null vs false

* Fix merge

* Fix up checkstyle whining

* One more failure

* Fix test

* wip

* changelog clarity

Co-authored-by: James Agnew <[email protected]>

* change index

---------

Co-authored-by: Michael Buckley <[email protected]>
Co-authored-by: James Agnew <[email protected]>
Co-authored-by: Ken Stevens <[email protected]>
* Add new workflow

* Add some whitespace

* Empty spaces in non-migration file

* wip

* Tidy up workflow
* Don't generate empty JSON element for comment

* Fixed
* 4379: allow interceptor annotation on methods

* 4379: document order parameter when annotation set on method

* Credit for #4380

---------

Co-authored-by: James Agnew <[email protected]>
)

* Parser: Reporting unexpected repeating element for choice (#4574)

IParserErrorHandler.unexpectedRepeatingElement is now also called for
unexpected repeating elements of type choice, where concrete names
may be different based on the choice's data type.

* setting test-utilities java version to the test version

* added changelog

* added Max to the developer liss

* removed unneeded dependency

---------

Co-authored-by: patrick-werner <[email protected]>
* Force Verify tests

* fix ITs (#4809)

* fix RestHookTestR5IT

* fix intermittent

---------

Co-authored-by: Ken Stevens <[email protected]>

* Fix migrator error on Oracle (#4814)

* Fix Oracle SQL error

* Add changelog

* Update clinical reasoning version (#4816)

* Update clinical reasoning version

* Update version

* Update version

* Clean-up and more wireup of evaluationSettings

* Add changelog

---------

Co-authored-by: Jonathan Percival <[email protected]>

* Opening the care-gaps endpoint for GET. (#4823)

Co-authored-by: Chalma Maadaadi <[email protected]>

* added version to mdm golden resource tag (#4820)

Co-authored-by: Long Ma <[email protected]>

* Update the changelog for 4697 to be more descriptive (#4827)

* Update the changelog for 4697 to be more descriptive

* Futher tweaks of the changelog

* Fixes a bug with tags.  (#4813)

* Test, fix

* Drop constraint, add migration

* Add changelog

* Fix userSelected null vs false

* Fix merge

* Fix up checkstyle whining

* One more failure

* Fix test

* wip

* changelog clarity

Co-authored-by: James Agnew <[email protected]>

* change index

---------

Co-authored-by: Michael Buckley <[email protected]>
Co-authored-by: James Agnew <[email protected]>

* fix migration issue (#4830)

Co-authored-by: Ken Stevens <[email protected]>

* Create correct version enum

* Remove superfluous migration

* fixing test (#4835)

Co-authored-by: leif stawnyczy <[email protected]>

---------

Co-authored-by: Ken Stevens <[email protected]>
Co-authored-by: Ken Stevens <[email protected]>
Co-authored-by: James Agnew <[email protected]>
Co-authored-by: Brenin Rhodes <[email protected]>
Co-authored-by: Jonathan Percival <[email protected]>
Co-authored-by: chalmarm <[email protected]>
Co-authored-by: Chalma Maadaadi <[email protected]>
Co-authored-by: longma1 <[email protected]>
Co-authored-by: Long Ma <[email protected]>
Co-authored-by: Michael Buckley <[email protected]>
Co-authored-by: TipzCM <[email protected]>
Co-authored-by: leif stawnyczy <[email protected]>
* Force Verify tests

* wip

* merge troubleshooting rel_6_6 troubleshooting changes

* fix ITs (#4809)

* fix RestHookTestR5IT

* fix intermittent

---------

Co-authored-by: Ken Stevens <[email protected]>

* post-merge cleanup

* fix test

* fix mock test

* fix wiring

* fix mock test

* fix test

* use IBaseResource.isDeleted()

* fixmes

* cleanup

* change log

---------

Co-authored-by: Tadgh <[email protected]>
Co-authored-by: Ken Stevens <[email protected]>
)

* A SNAPSHOT dependency on an upstream module was added to HAPI FHIR, which changed and caused some downstream tests to break.

* Add Maven enforcer plugin for CR dependencies

* Make maven enforcer conditional on CI builds
* add test proving bug

* fix: handle empty fromValue in TerserUtil.replaceField

* add comment to TerserUtilTest.testReplaceFieldByEmptyValue
* Add credit

* Typo
* add tests for fhir patch

* extract constants

* extract some methods

* isolate add operation

* isolate delete operation

* isolate replace operation

* isolate move operation

* clean up integer handling

* enumeration creation

* improve variable naming

* code review feedback
* enforce no exceptions on the invoking thread in PointCutLatch

* comment

* Msg.code

* Catch exceptions outside of await block

* fix migration issue

* Refactor PointcutLatch and add tests

* fix tests

* fix tests

* fix tests

* fix test

* fix test

* fix test

* fix test

* fix test

* fix test

* fix test

* fix test

* fix test

* fix test

* fix test!

* fix test!

* fix test

* fix test

* clean up latch error formatting

* fix test

* fix test

* fix test

* fix test

* fix test

* fix tests

* fix test

* fix test

* Remove hapi-fhir-jpaserver-uhnfhirtest from build as it is crashing CI

* fix test

* fix intermittent

* A SNAPSHOT dependency on an upstream module was added to HAPI FHIR, which changed and caused some downstream tests to break.

* fix intermittent

* Add Maven enforcer plugin for CR dependencies

* Make maven enforcer conditional on CI builds

* Remove hapi-fhir-jpaserver-uhnfhirtest from build as it is crashing CI

* improve test logging

* pre-review cleanup

* review feedback

* remove hapi-fhir-base-test-jaxrsserver-kotlin from the build

---------

Co-authored-by: Ken Stevens <[email protected]>
Co-authored-by: Jonathan Percival <[email protected]>
Match the pattern used by Grahame in this update of kindling: HL7/kindling@f765642
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet