Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix previous links in the plain server #4707

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jmb6g
Copy link

@jmb6g jmb6g commented Mar 31, 2023

Provide a fix for cases where the previous links can be incorrect in the plain server. This was reported in #4705.

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.18 🎉

Comparison is base (2f5ffe7) 81.32% compared to head (315d7f1) 81.51%.

❗ Current head 315d7f1 differs from pull request most recent head b88d791. Consider uploading reports for the commit b88d791 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4707      +/-   ##
============================================
+ Coverage     81.32%   81.51%   +0.18%     
- Complexity    23650    24345     +695     
============================================
  Files          1425     1464      +39     
  Lines         86399    89009    +2610     
  Branches      11677    11993     +316     
============================================
+ Hits          70265    72556    +2291     
- Misses        10947    11157     +210     
- Partials       5187     5296     +109     

see 1414 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmb6g jmb6g changed the title Update BaseResourceReturningMethodBinding.java Fix previous links f in the plain server Apr 1, 2023
@jmb6g jmb6g changed the title Fix previous links f in the plain server Fix previous links in the plain server Apr 1, 2023
@jamesagnew
Copy link
Collaborator

Hi @jmb6g - Thanks for the contribution, are you able to add a test that demonstrates the fix?

@jmb6g
Copy link
Author

jmb6g commented Apr 11, 2023

Hi @jmb6g - Thanks for the contribution, are you able to add a test that demonstrates the fix?

Not yet. I have not set up an environment to build locally. I just spotted the flaw during our use of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants