-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instance level reindex operations #4699
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #4699 +/- ##
============================================
+ Coverage 81.32% 81.60% +0.27%
- Complexity 23650 24420 +770
============================================
Files 1425 1470 +45
Lines 86399 89409 +3010
Branches 11677 12015 +338
============================================
+ Hits 70265 72963 +2698
- Misses 10947 11142 +195
- Partials 5187 5304 +117 see 1419 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few todos and comments
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/BaseHapiFhirResourceDao.java
Outdated
Show resolved
Hide resolved
...in/resources/ca/uhn/hapi/fhir/changelog/6_6_0/4699-combo-nonunique-searchparams-updates.yaml
Outdated
Show resolved
Hide resolved
...-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/index/DaoSearchParamSynchronizer.java
Show resolved
Hide resolved
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/BaseHapiFhirDao.java
Outdated
Show resolved
Hide resolved
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/provider/ReindexDryRunProvider.java
Outdated
Show resolved
Hide resolved
...chparam/src/main/java/ca/uhn/fhir/jpa/searchparam/extractor/SearchParamExtractorService.java
Outdated
Show resolved
Hide resolved
...chparam/src/main/java/ca/uhn/fhir/jpa/searchparam/extractor/SearchParamExtractorService.java
Outdated
Show resolved
Hide resolved
...-jpaserver-test-r4/src/test/java/ca/uhn/fhir/jpa/dao/r4/FhirResourceDaoR4QueryCountTest.java
Show resolved
Hide resolved
...-jpaserver-test-r4/src/test/java/ca/uhn/fhir/jpa/dao/r4/FhirResourceDaoR4QueryCountTest.java
Outdated
Show resolved
Hide resolved
...ver-test-r5/src/test/java/ca/uhn/fhir/jpa/search/reindex/InstanceReindexServiceImplTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great piece of work!
This PR adds an instance level $reindex operation, as well as a dry-run equivalent for testing reindexing