Use java event names for work chunk transitions. #4658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #4658 +/- ##
============================================
+ Coverage 81.32% 81.57% +0.25%
- Complexity 23650 24196 +546
============================================
Files 1425 1449 +24
Lines 86399 88463 +2064
Branches 11677 11917 +240
============================================
+ Hits 70265 72168 +1903
- Misses 10947 11026 +79
- Partials 5187 5269 +82 see 252 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
lukedegruchy
approved these changes
Mar 21, 2023
hapi-fhir-storage-batch2/src/main/java/ca/uhn/fhir/batch2/model/WorkChunkCreateEvent.java
Show resolved
Hide resolved
hapi-fhir-storage-batch2/src/main/java/ca/uhn/fhir/batch2/model/WorkChunk.java
Show resolved
Hide resolved
hapi-fhir-storage-batch2/src/main/java/ca/uhn/fhir/batch2/coordinator/BatchWorkChunk.java
Show resolved
Hide resolved
hapi-fhir-storage-batch2/src/main/java/ca/uhn/fhir/batch2/coordinator/JobDataSink.java
Show resolved
Hide resolved
tadgh
pushed a commit
that referenced
this pull request
Apr 26, 2023
Change work-chunk creation to be first event in state machine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change work-chunk creation to be an event, and rename WorkChunk event methods in IWorkChunkPersistence to use Java event handler names.