Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove methods deprecated in 4485. #4599

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove methods deprecated in 4485. #4599

wants to merge 1 commit into from

Conversation

lukedegruchy
Copy link
Collaborator

No description provided.

@lukedegruchy lukedegruchy marked this pull request as ready for review February 27, 2023 15:01
JasonRoberts-smile
JasonRoberts-smile approved these changes Feb 27, 2023
View reviewed changes
Copy link
Collaborator

@JasonRoberts-smile JasonRoberts-smile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may be wrong, but I thought that we usually gave community implementers more than a single release cycle to address deprecated methods before deleting them.

@lukedegruchy
Copy link
Collaborator Author

I may be wrong, but I thought that we usually gave community implementers more than a single release cycle to address deprecated methods before deleting them.

@JasonRoberts-smile Who would give the definitive answer to this question? If you're right, this is not adviseable.

@JasonRoberts-smile
Copy link
Collaborator

I may be wrong, but I thought that we usually gave community implementers more than a single release cycle to address deprecated methods before deleting them.

@JasonRoberts-smile Who would give the definitive answer to this question? If you're right, this is not adviseable.

I'd suggest checking with Gary, but he's got a lot on his plate right now. Maybe Mark?

@lukedegruchy
Copy link
Collaborator Author

After discussing this, everybody agrees with @JasonRoberts-smile and I'll put in a reminder to merge this 3 months from now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonRoberts-smile JasonRoberts-smile JasonRoberts-smile approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukedegruchy @JasonRoberts-smile