Possible duplication of resources on conditional create/update #4598
48 new issues (0 max.) of at least minor severity.
Annotations
Check warning on line 136 in hapi-fhir-base/src/main/java/ca/uhn/fhir/model/api/Tag.java
codacy-production / Codacy Static Code Analysis
hapi-fhir-base/src/main/java/ca/uhn/fhir/model/api/Tag.java#L136
Avoid unnecessary if..then..else statements when returning booleans
codacy-production / Codacy Static Code Analysis
hapi-fhir-cli/hapi-fhir-cli-api/src/test/java/ca/uhn/fhir/cli/HapiClearMigrationLockCommandTest.java#L61
Avoid unused local variables such as 'beforeClearMigrationCount'.
codacy-production / Codacy Static Code Analysis
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/index/IdHelperService.java#L154
Avoid reassigning parameters such as 'theResourceId'
codacy-production / Codacy Static Code Analysis
hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/bulk/export/svc/BulkDataExportJobSchedulingHelperImplTest.java#L132
The JUnit 5 test method name 'purgeExpiredFilesSingleJobSingleBinaryOneHourRetention_BAD_reportString' doesn't match '[a-z][a-zA-Z0-9]*'
codacy-production / Codacy Static Code Analysis
hapi-fhir-jpaserver-subscription/src/main/java/ca/uhn/fhir/jpa/subscription/submit/interceptor/SubscriptionValidatingInterceptor.java#L102
The method 'validateSubmittedSubscription(IBaseResource, RequestDetails, RequestPartitionId, Pointcut)' has an NPath complexity of 3000, current threshold is 200
codacy-production / Codacy Static Code Analysis
hapi-fhir-jpaserver-subscription/src/test/java/ca/uhn/fhir/jpa/subscription/submit/interceptor/SubscriptionMatcherInterceptorTest.java#L39
The JUnit 5 test method name 'testMethodStartIfNeeded_withQualifySubscriptionMatchingChannelNameProperty_mayQualifyChannelName' doesn't match '[a-z][a-zA-Z0-9]*'
codacy-production / Codacy Static Code Analysis
hapi-fhir-jpaserver-test-r4/src/test/java/ca/uhn/fhir/jpa/batch2/JpaJobPersistenceImplTest.java#L167
The JUnit 5 test method name 'testFetchInstanceWithStatusAndCutoff_cutoffs' doesn't match '[a-z][a-zA-Z0-9]*'
codacy-production / Codacy Static Code Analysis
hapi-fhir-jpaserver-test-r4/src/test/java/ca/uhn/fhir/jpa/batch2/JpaJobPersistenceImplTest.java#L195
The JUnit 5 test method name 'testFetchInstanceWithStatusAndCutoff_pages' doesn't match '[a-z][a-zA-Z0-9]*'
codacy-production / Codacy Static Code Analysis
hapi-fhir-jpaserver-test-r4/src/test/java/ca/uhn/fhir/jpa/dao/r4/FhirResourceDaoR4ConcurrentCreateTest.java#L56
The JUnit 5 test method name 'testMultipleThreads_attemptingToCreatingTheSameResource_willCreateOnlyOneResource' doesn't match '[a-z][a-zA-Z0-9]*'
codacy-production / Codacy Static Code Analysis
hapi-fhir-jpaserver-test-r4/src/test/java/ca/uhn/fhir/jpa/dao/r4/FhirResourceDaoR4ConcurrentCreateTest.java#L92
Avoid unused local variables such as 'outcome'.
codacy-production / Codacy Static Code Analysis
hapi-fhir-jpaserver-test-r4/src/test/java/ca/uhn/fhir/jpa/dao/r4/FhirResourceDaoR4CreateTest.java#L93
JUnit tests should include assert() or fail()
codacy-production / Codacy Static Code Analysis
hapi-fhir-jpaserver-test-r4/src/test/java/ca/uhn/fhir/jpa/delete/job/ReindexJobTest.java#L98
JUnit tests should include assert() or fail()
codacy-production / Codacy Static Code Analysis
hapi-fhir-jpaserver-test-r4/src/test/java/ca/uhn/fhir/jpa/delete/job/ReindexJobTest.java#L98
The JUnit 5 test method name 'testReindexDeletedResources_byUrl_willRemoveDeletedResourceEntriesFromIndexTables' doesn't match '[a-z][a-zA-Z0-9]*'
codacy-production / Codacy Static Code Analysis
hapi-fhir-storage-batch2-jobs/src/test/java/ca/uhn/fhir/batch2/jobs/imprt/BulkDataImportProviderTest.java#L80
The JUnit 5 test method name 'testStart_Success' doesn't match '[a-z][a-zA-Z0-9]*'
codacy-production / Codacy Static Code Analysis
hapi-fhir-storage-batch2/src/test/java/ca/uhn/fhir/batch2/coordinator/WorkChunkProcessorTest.java#L143
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.
codacy-production / Codacy Static Code Analysis
hapi-fhir-test-utilities/src/test/java/ca/uhn/fhir/test/utilities/RangeTestHelperTest.java#L15
JUnit tests should include assert() or fail()
codacy-production / Codacy Static Code Analysis
hapi-fhir-test-utilities/src/test/java/ca/uhn/fhir/test/utilities/RangeTestHelperTest.java#L21
Avoid unused local variables such as 'thrown'.
codacy-production / Codacy Static Code Analysis
hapi-fhir-test-utilities/src/test/java/ca/uhn/fhir/test/utilities/RangeTestHelperTest.java#L28
JUnit tests should include assert() or fail()
codacy-production / Codacy Static Code Analysis
hapi-fhir-validation/src/main/java/org/hl7/fhir/common/hapi/validation/support/CommonCodeSystemsTerminologyService.java#L569
Unnecessary use of fully qualified name 'org.hl7.fhir.r5.model.Resource' due to existing import 'org.hl7.fhir.r5.model.Resource'
codacy-production / Codacy Static Code Analysis
hapi-fhir-validation/src/test/java/org/hl7/fhir/r4b/validation/FhirInstanceValidatorR4BTest.java#L126
The method 'before()' has an NPath complexity of 288, current threshold is 200
codacy-production / Codacy Static Code Analysis
hapi-fhir-validation/src/test/java/org/hl7/fhir/r4b/validation/FhirInstanceValidatorR4BTest.java#L876
JUnit tests should include assert() or fail()
codacy-production / Codacy Static Code Analysis
hapi-fhir-validation/src/test/java/org/hl7/fhir/r4b/validation/FhirInstanceValidatorR4BTest.java#L1521
The JUnit 5 test method name 'testPatientSingleCommunicationLanguage_en' doesn't match '[a-z][a-zA-Z0-9]*'
codacy-production / Codacy Static Code Analysis
hapi-fhir-validation/src/test/java/org/hl7/fhir/r4b/validation/FhirInstanceValidatorR4BTest.java#L1551
The JUnit 5 test method name 'testPatientMultipleCommunicationLanguages_en_US_and_en_UNDERSCORE_config_true' doesn't match '[a-z][a-zA-Z0-9]*'
codacy-production / Codacy Static Code Analysis
hapi-fhir-validation/src/test/java/org/hl7/fhir/r4b/validation/FhirInstanceValidatorR4BTest.java#L1562
The JUnit 5 test method name 'testPatientMultipleCommunicationLanguages_en_US_and_en_UNDERSCORE_config_false' doesn't match '[a-z][a-zA-Z0-9]*'
codacy-production / Codacy Static Code Analysis
hapi-fhir-validation/src/test/java/org/hl7/fhir/r4b/validation/FhirInstanceValidatorR4BTest.java#L1572
The JUnit 5 test method name 'testPatientMultipleCommunicationLanguages_en_US_and_en_DASH' doesn't match '[a-z][a-zA-Z0-9]*'