Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE UNTIL 6.3.15-SNAPSHOT is published: Delete methods deprecated in 4485. #4488

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

lukedegruchy
Copy link
Collaborator

No description provided.

jamesagnew and others added 6 commits January 27, 2023 08:30
* Adding initial test.

* Adding fix and subsequent test.

* Adding changelog.

---------

Co-authored-by: peartree <[email protected]>
…atching channel be unqualified (#4464)

* Adding initial test.

* Adding initial solution implementation.

* Adding change log and code clean up.

* addressing comments from 1st code review.

---------

Co-authored-by: peartree <[email protected]>
* change migration visibility

* add empty migration method for 640

---------

Co-authored-by: nathaniel.doef <[email protected]>
… from an update pointcut (#4484)

* First commit:  Make SubscriptionValidatingInterceptor aware of which Pointcut is being called.  In validatePermissions(), skip determinePartition() if the Pointcut is STORAGE_PRESTORAGE_RESOURCE_UPDATED.   Fix resulting compile errors in various unit tests.

* Fix/enhance unit tests.  Mark methods as deprecated instead of deleting them.  Add proper error code.  Complete changelog.

* Remove erroneous TODOs and tweak the validation logic.

* Enhance unit tests and fix changelog.
@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Base: 81.32% // Head: 81.34% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (0a08c9f) compared to base (2f5ffe7).
Patch has no changes to coverable lines.

❗ Current head 0a08c9f differs from pull request most recent head 5db8e5b. Consider uploading reports for the commit 5db8e5b to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4488      +/-   ##
============================================
+ Coverage     81.32%   81.34%   +0.02%     
- Complexity    23650    23816     +166     
============================================
  Files          1425     1432       +7     
  Lines         86399    87325     +926     
  Branches      11677    11785     +108     
============================================
+ Hits          70265    71038     +773     
- Misses        10947    11046      +99     
- Partials       5187     5241      +54     
Impacted Files Coverage Δ
ca/uhn/fhir/mdm/api/MdmQuerySearchParameters.java 49.31% <0.00%> (-35.94%) ⬇️
org/hl7/fhir/r5/hapi/fhirpath/FhirPathR5.java 40.74% <0.00%> (-28.01%) ⬇️
ca/uhn/fhir/mdm/provider/MdmProviderLoader.java 12.50% <0.00%> (-25.00%) ⬇️
...a/uhn/fhir/jpa/mdm/svc/MdmLinkQuerySvcImplSvc.java 41.66% <0.00%> (-25.00%) ⬇️
org/hl7/fhir/r4/hapi/fluentpath/FhirPathR4.java 62.96% <0.00%> (-24.54%) ⬇️
.../hl7/fhir/dstu3/hapi/fluentpath/FhirPathDstu3.java 76.00% <0.00%> (-17.75%) ⬇️
.../rest/server/provider/ResourceProviderFactory.java 65.00% <0.00%> (-15.00%) ⬇️
ca/uhn/fhir/jpa/mdm/svc/MdmControllerSvcImpl.java 63.44% <0.00%> (-9.40%) ⬇️
...hn/fhir/jpa/mdm/broker/MdmQueueConsumerLoader.java 61.90% <0.00%> (-6.85%) ⬇️
...r/narrative/CustomThymeleafNarrativeGenerator.java 94.73% <0.00%> (-5.27%) ⬇️
... and 98 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lukedegruchy lukedegruchy changed the title Delete methods deprecated in 4485. DO NOT MERGE UNTIL 6.3.15-SNAPSHOT is published: Delete methods deprecated in 4485. Jan 31, 2023
Copy link
Collaborator

@jmarchionatto jmarchionatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good move! Maybe you want to expose the method in a tech talk?

@lukedegruchy lukedegruchy changed the base branch from rel_6_4 to master February 13, 2023 14:52
…ption-validating-interceptor-remove-deprecated-methods
…ption-validating-interceptor-remove-deprecated-methods
@lukedegruchy lukedegruchy marked this pull request as ready for review May 29, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants