DO NOT MERGE UNTIL 6.3.15-SNAPSHOT is published: Delete methods deprecated in 4485. #4488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding initial test. * Adding fix and subsequent test. * Adding changelog. --------- Co-authored-by: peartree <[email protected]>
…atching channel be unqualified (#4464) * Adding initial test. * Adding initial solution implementation. * Adding change log and code clean up. * addressing comments from 1st code review. --------- Co-authored-by: peartree <[email protected]>
* change migration visibility * add empty migration method for 640 --------- Co-authored-by: nathaniel.doef <[email protected]>
… from an update pointcut (#4484) * First commit: Make SubscriptionValidatingInterceptor aware of which Pointcut is being called. In validatePermissions(), skip determinePartition() if the Pointcut is STORAGE_PRESTORAGE_RESOURCE_UPDATED. Fix resulting compile errors in various unit tests. * Fix/enhance unit tests. Mark methods as deprecated instead of deleting them. Add proper error code. Complete changelog. * Remove erroneous TODOs and tweak the validation logic. * Enhance unit tests and fix changelog.
Codecov ReportBase: 81.32% // Head: 81.34% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4488 +/- ##
============================================
+ Coverage 81.32% 81.34% +0.02%
- Complexity 23650 23816 +166
============================================
Files 1425 1432 +7
Lines 86399 87325 +926
Branches 11677 11785 +108
============================================
+ Hits 70265 71038 +773
- Misses 10947 11046 +99
- Partials 5187 5241 +54
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
lukedegruchy
changed the title
jmarchionatto
approved these changes
Feb 1, 2023
…ption-validating-interceptor-remove-deprecated-methods
…ption-validating-interceptor-remove-deprecated-methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.