-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE UNTIL 6.3.15-SNAPSHOT is published: Delete methods deprecated in 4485. #4488
base: master
Are you sure you want to change the base?
DO NOT MERGE UNTIL 6.3.15-SNAPSHOT is published: Delete methods deprecated in 4485. #4488
Conversation
* Adding initial test. * Adding fix and subsequent test. * Adding changelog. --------- Co-authored-by: peartree <[email protected]>
…atching channel be unqualified (#4464) * Adding initial test. * Adding initial solution implementation. * Adding change log and code clean up. * addressing comments from 1st code review. --------- Co-authored-by: peartree <[email protected]>
* change migration visibility * add empty migration method for 640 --------- Co-authored-by: nathaniel.doef <[email protected]>
… from an update pointcut (#4484) * First commit: Make SubscriptionValidatingInterceptor aware of which Pointcut is being called. In validatePermissions(), skip determinePartition() if the Pointcut is STORAGE_PRESTORAGE_RESOURCE_UPDATED. Fix resulting compile errors in various unit tests. * Fix/enhance unit tests. Mark methods as deprecated instead of deleting them. Add proper error code. Complete changelog. * Remove erroneous TODOs and tweak the validation logic. * Enhance unit tests and fix changelog.
Codecov ReportBase: 81.32% // Head: 81.34% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4488 +/- ##
============================================
+ Coverage 81.32% 81.34% +0.02%
- Complexity 23650 23816 +166
============================================
Files 1425 1432 +7
Lines 86399 87325 +926
Branches 11677 11785 +108
============================================
+ Hits 70265 71038 +773
- Misses 10947 11046 +99
- Partials 5187 5241 +54
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good move! Maybe you want to expose the method in a tech talk?
…ption-validating-interceptor-remove-deprecated-methods
…ption-validating-interceptor-remove-deprecated-methods
No description provided.