Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introducing a checkstyle error to test pipeline #4346

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

introducing a checkstyle error to test pipeline #4346

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6c502e
introducing a checkstyle error to test pipeline
markiantorno Dec 8, 2022
6b4b137
Adding cross module checkstyle error
markiantorno Dec 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Adding cross module checkstyle error
  • Loading branch information
@markiantorno
markiantorno committed Dec 9, 2022
commit 6b4b1370a43c886ac8358dd73903b58f041dc95a
13 changes: 0 additions & 13 deletions hapi-fhir-client/src/main/java/ca/uhn/fhir/rest/client/apache/ApacheHttpResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,6 @@ public void bufferEntity() throws IOException {
try {
this.myEntityBytes = IOUtils.toByteArray(respEntity);
} catch (IllegalStateException e) {
for (int x = 0; x<10; x++) {
System.out.println("poop");
System.out.println("poop2");
System.out.println("poop2");
System.out.println("poop2");
}
throw new InternalErrorException(Msg.code(1478) + e);
}
}
Expand All @@ -84,14 +78,7 @@ public void close() {
try {
((CloseableHttpResponse) myResponse).close();
} catch (IOException e) {
for (int x = 0; x<10; x++) {
System.out.println("poop");
System.out.println("poop2");
System.out.println("poop2");
System.out.println("poop2");
}
ourLog.debug("Failed to close response", e);
throw new InternalErrorException(Msg.code(1478) + e);
}
}
}
Expand Down
5 changes: 4 additions & 1 deletion hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/BaseHapiFhirResourceDao.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@
import ca.uhn.fhir.rest.server.IRestfulServerDefaults;
import ca.uhn.fhir.rest.server.RestfulServerUtils;
import ca.uhn.fhir.rest.server.exceptions.BaseServerResponseException;
import ca.uhn.fhir.rest.server.exceptions.InternalErrorException;
import ca.uhn.fhir.rest.server.exceptions.InvalidRequestException;
import ca.uhn.fhir.rest.server.exceptions.MethodNotAllowedException;
import ca.uhn.fhir.rest.server.exceptions.PreconditionFailedException;
Expand Down Expand Up @@ -731,7 +732,9 @@ public void beforeCommit(boolean readOnly) {
private void validateDeleteEnabled() {
if (!getConfig().isDeleteEnabled()) {
String msg = getContext().getLocalizer().getMessage(BaseStorageDao.class, "deleteBlockedBecauseDisabled");
throw new PreconditionFailedException(Msg.code(966) + msg);
// throw new PreconditionFailedException(Msg.code(966) + msg);
throw new InternalErrorException(Msg.code(1478) + msg);

}
}

Expand Down