Fix circular dependency in SnapshotGeneratingValidationSupport

[ABDA-FHIR]

Correct scoping for the finally frame that undoes the addition of the input URL to the 'currently generating snapshots' hash set.

[jamesagnew]

Can you please add a unit test that exercizes this fix?

[ABDA-FHIR]

coming soon....
...until then #3942 -> https://gist.github.com/joergreichert/8d0c714cfb2d3c5a7eef1bdc0e9be097

[codecov]

Codecov Report

Base: 81.86% // Head: 81.02% // Decreases project coverage by -0.83% ⚠️

Coverage data is based on head (a278d5c) compared to base (e7a4c49).
Patch has no changes to coverable lines.

❗ Current head a278d5c differs from pull request most recent head efc6442. Consider uploading reports for the commit efc6442 to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #4228      +/-   ##
============================================
- Coverage     81.86%   81.02%   -0.84%     
- Complexity    20838    23466    +2628     
============================================
  Files          1421     1445      +24     
  Lines         77246    86143    +8897     
  Branches      11078    11792     +714     
============================================
+ Hits          63236    69800    +6564     
- Misses         9866    11068    +1202     
- Partials       4144     5275    +1131     

Impacted Files	Coverage Δ
...a/uhn/fhir/context/BaseRuntimeChildDefinition.java
...ir/context/BaseRuntimeDeclaredChildDefinition.java
...src/main/java/ca/uhn/fhir/context/FhirContext.java
...main/java/ca/uhn/fhir/context/FhirVersionEnum.java
...rc/main/java/ca/uhn/fhir/context/ModelScanner.java
...ca/uhn/fhir/context/RuntimeResourceDefinition.java
...n/java/ca/uhn/fhir/context/RuntimeSearchParam.java
...-fhir-base/src/main/java/ca/uhn/fhir/i18n/Msg.java
...ain/java/ca/uhn/fhir/interceptor/api/Pointcut.java
...r/interceptor/executor/BaseInterceptorService.java
... and 2842 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.