Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueSet cleanup #4227

Merged
merged 51 commits into from
Nov 9, 2022
Merged

Conversation

jamesagnew
Copy link
Collaborator

@jamesagnew jamesagnew commented Nov 1, 2022

Fixes #4206

This PR:

  • Fixes the issue above
  • Adds more resiliency to HAPI FHIR Batch2 processing (bringing it more in line with how this works in Smile)
  • Removes a whole bunch of version-specific JPA code for CodeSystem/ValueSet operations, replacing that with a single version independent codebase

@codecov
Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Base: 81.00% // Head: 81.10% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (4a43b69) compared to base (02944ba).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4227      +/-   ##
============================================
+ Coverage     81.00%   81.10%   +0.10%     
+ Complexity    23466    23452      -14     
============================================
  Files          1446     1438       -8     
  Lines         86175    86073     -102     
  Branches      11798    11748      -50     
============================================
+ Hits          69809    69813       +4     
+ Misses        11087    11022      -65     
+ Partials       5279     5238      -41     
Impacted Files Coverage Δ
...ir/jpa/provider/r4/BaseResourceProviderR4Test.java 0.00% <0.00%> (-95.32%) ⬇️
...uhn/fhir/jpa/term/config/TermCodeSystemConfig.java 75.00% <0.00%> (-25.00%) ⬇️
...bscription/channel/impl/LinkedBlockingChannel.java 72.72% <0.00%> (-17.28%) ⬇️
ca/uhn/fhir/jpa/test/config/TestJPAConfig.java 87.50% <0.00%> (-12.50%) ⬇️
ca/uhn/fhir/jpa/provider/BaseJpaProvider.java 52.54% <0.00%> (-7.81%) ⬇️
ca/uhn/fhir/util/ThreadPoolUtil.java 93.33% <0.00%> (-6.67%) ⬇️
...or/TransactionConcurrencySemaphoreInterceptor.java 80.59% <0.00%> (-5.98%) ⬇️
...terceptor/SubscriptionSubmitInterceptorLoader.java 94.44% <0.00%> (-5.56%) ⬇️
ca/uhn/fhir/jpa/util/MemoryCacheService.java 85.10% <0.00%> (-3.20%) ⬇️
.../interceptor/SearchParamValidatingInterceptor.java 85.84% <0.00%> (-1.32%) ⬇️
... and 87 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jamesagnew jamesagnew merged commit b3ebbe7 into master Nov 9, 2022
@jamesagnew jamesagnew deleted the ja_20221101_4206_concept_reindex_job_fails branch November 9, 2022 03:18
michaelabuckley added a commit that referenced this pull request Nov 11, 2022
…d-id-inline

* commit '9a45576793a279ba1722853ab7c847745595b22e':
  Cache service loaders (#4196)
  Post release HAPI FHIR cleanup (#4266)
  Bump log4j-to-slf4j from 2.17.1 to 2.19.0 (#4265)
  ValueSet cleanup (#4227)
  Rel 6 2 mergeback (#4257)
  Issue 4180 process slows down to a crawl while loading uscore ig (#4201)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Batch2 job left in IN_PROGRESS blocks scheduled pre-expansion of ValueSets
3 participants