Fix sort in hsearch - use full millis #3787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ilities/src/test/java/ca/uhn/fhir/jpa/dao/r4/FhirResourceDaoR4SearchWithElasticSearchIT.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #3787 +/- ##
============================================
+ Coverage 83.40% 83.41% +0.01%
- Complexity 21813 21817 +4
============================================
Files 1434 1434
Lines 78165 78165
Branches 11553 11553
============================================
+ Hits 65196 65204 +8
+ Misses 8526 8521 -5
+ Partials 4443 4440 -3
Continue to review full report at Codecov.
|
jmarchionatto
approved these changes
Jul 13, 2022
michaelabuckley
added a commit
that referenced
this pull request
Aug 8, 2022
* commit '0a1e782a8ea4c29eb490836ebd0360c3e6999635': (81 commits) 3817 enhance subscription before message delivery (#3824) 3755 use batch2 job after search parameter change (#3806) separate elastic tests into their own project (#3827) Document the need to reindex when enabling full resource storage with indexed resources. (#3815) fix checkstyle test passes with a lot of copy/paste Issue 3804 application fails to start 610 pre14 snapshot with beandefinitionoverrideexception invalid bean definition with name loadidsstep (#3805) Implement patch in mongo db (#3781) 3531 implement bulk processors (#3566) Hsearch no scroll queries (#3799) 3770 fix batch2 failure loop (#3779) Make patch `add` actually add instead of replace. (#3800) Adding autoclosing for sonatype publishing (#3798) 3664 fast elastic load (#3769) 3788 FHIR patch on soft deleted resource undeletes resource (#3789) 3790 remove legacy search builder (#3791) Fix sort in hsearch - use full millis (#3787) Mb implement token :not inmemory (#3784) Changelog Bump jetty-http from 9.4.44.v20210927 to 9.4.48.v20220622 (#3766) ... # Conflicts: # hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/search/ExtendedHSearchClauseBuilder.java # hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/search/ExtendedHSearchIndexExtractor.java # hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/search/ExtendedHSearchSearchBuilder.java # hapi-fhir-jpaserver-elastic-test-utilities/src/test/java/ca/uhn/fhir/jpa/dao/r4/FhirResourceDaoR4SearchWithElasticSearchIT.java # hapi-fhir-jpaserver-model/src/main/java/ca/uhn/fhir/jpa/model/search/ExtendedHSearchIndexData.java # hapi-fhir-jpaserver-model/src/main/java/ca/uhn/fhir/jpa/model/search/HSearchIndexWriter.java # hapi-fhir-jpaserver-model/src/main/java/ca/uhn/fhir/jpa/model/search/SearchParamTextPropertyBinder.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were sorting on the date ordinal, not the timestamp.