3664 search result indexing #3691
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Search result caching is on the query hot-path. We can use the natural composite key instead of the pid here.
tadgh
approved these changes
Jun 13, 2022
...ir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/migrate/tasks/HapiFhirJpaMigrationTasks.java
Show resolved
Hide resolved
|
|
||
| @Modifying | ||
| @Query("DELETE FROM SearchResult r WHERE r.mySearchPid = :search and r.myOrder >= :rangeStart and r.myOrder < :rangeStart + :maxCount") | ||
| int deleteForParentWithLimit(@Param("search") Long theSearchPid, @Param("rangeStart") int theStart, @Param("maxCount") int theCount); |
There was a problem hiding this comment.
Question: Does this mean parent as in parent Search ? I guess I'm confused by what parent means here
There was a problem hiding this comment.
Yes. I'll rename.
hapi-fhir-sql-migrate/src/main/java/ca/uhn/fhir/jpa/migrate/tasks/api/Builder.java
Show resolved
Hide resolved
hapi-fhir-sql-migrate/src/test/java/ca/uhn/fhir/jpa/migrate/taskdef/AddPrimaryKeyTaskTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid the database traffic required for sequence fetching by using a natural composite PK.
Supports #3664
Addresses #866