Issue 3441 reindex query being ignored #3451
Conversation
| public void testReindexJobLastUpdatedFilter() throws Exception { | ||
| // Given | ||
| DaoMethodOutcome T1_Patient = myReindexTestHelper.createEyeColourPatient(true); | ||
| Thread.sleep(3000); |
There was a problem hiding this comment.
Nitpick - Instead of sleeping for 3 seconds and using that interval to calculate T2_date and T4_date below, I'd recommend using sleepUntilTimeChanges() and grabbing the actual timestamps before and after. This reduces the pause time, and also guarantees that you don't get any weird side effects from clock inaccuracies (calling Thread.sleep(3000) can actually result in a delay that is higher or lower than that number)
There was a problem hiding this comment.
Makes sense. I updated the code. Thanks.
Codecov Report
@@ Coverage Diff @@
## master #3451 +/- ##
=========================================
Coverage 83.03% 83.04%
- Complexity 20980 20987 +7
=========================================
Files 1406 1406
Lines 75373 75384 +11
Branches 11236 11239 +3
=========================================
+ Hits 62583 62599 +16
+ Misses 8473 8469 -4
+ Partials 4317 4316 -1
Continue to review full report at Codecov.
|
…-fast-path-elastic * commit '92db526786ebeb9cde434483c5695ce8a5f4db2d': Skip database query when hibernate search fully satisfies search (#3478) Revert change to treat Canonical URLs as Locals (#3483) review feedback Convert Reindex into Batch2 Job (#3458) Issue 3450 there is no way to recreate freetext indexes for terminology entities (#3481) Issue 3450 there is no way to recreate freetext indexes for terminology entities (#3463) Rel 5 7 1 mergeback (#3480) Issue 3441 reindex query being ignored (#3451) # Conflicts: # hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/FulltextSearchSvcImpl.java # hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/search/builder/SearchBuilder.java # hapi-fhir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/r4/FhirResourceDaoR4SearchWithElasticSearchIT.java # hapi-fhir-jpaserver-model/src/main/java/ca/uhn/fhir/jpa/model/entity/ResourceTable.java # hapi-fhir-jpaserver-model/src/main/java/ca/uhn/fhir/jpa/model/search/ExtendedLuceneIndexData.java
This fixes 3441.