Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPEs in DefaultProfileValidationSupport #2690

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix NPEs in DefaultProfileValidationSupport #2690

wants to merge 1 commit into from

Conversation

rld4l
Copy link

@rld4l rld4l commented May 31, 2021

No description provided.

@jamesagnew
Copy link
Collaborator

Hi @rld4l - Thanks for the contribution!

I'm wondering, I can see how the code you fixed would result in an NPE if fetchAllConformanceResources is the first method ever called on that object. Doesn't this fix just hide the real issue though, whcih is that the resources haven't been loaded yet? I'm worried about the consequences of this method returning an empty list.

Would it make more sense to actually rework it so that if these variables are null, we just load the real contents first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rld4l @jamesagnew