Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing mandatory field in loinc.xml. The codesystem will fail the Ha… #1611

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

basecade
Copy link
Contributor

Missing mandatory field in loinc.xml. The codesystem will fail the Hapi validation if this is not set.

https://groups.google.com/forum/#!topic/hapi-fhir/Z2p5Uo1ds80

@codecov
Copy link

codecov bot commented Nov 27, 2019

Codecov Report

Merging #1611 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1611      +/-   ##
============================================
+ Coverage     79.05%   79.05%   +<.01%     
  Complexity    13293    13293              
============================================
  Files           920      920              
  Lines         51131    51131              
  Branches       8285     8285              
============================================
+ Hits          40420    40423       +3     
+ Misses         7538     7537       -1     
+ Partials       3173     3171       -2
Impacted Files Coverage Δ Complexity Δ
.../java/ca/uhn/fhir/rest/param/QualifierDetails.java 75% <0%> (-1.67%) 25% <0%> (-1%)
...main/java/ca/uhn/fhir/jpa/dao/BaseHapiFhirDao.java 90.88% <0%> (+0.26%) 224% <0%> (+1%) ⬆️
.../jpa/search/reindex/ResourceReindexingSvcImpl.java 91.88% <0%> (+0.85%) 48% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df57d24...d4ddcdf. Read the comment docs.

@jamesagnew
Copy link
Collaborator

Thanks @basecade - FYI I have notified the LOINC team just to confirm that they're good with these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants