Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preventing infinite recursion when two resources that have a referenc… #1609

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

basecade
Copy link
Contributor

Preventing infinite recursion when two resources that have a reference to each other are created in the same transaction.

Problem: the id of the resources is null in this case and that causes the loop because of the check

https://groups.google.com/forum/#!topic/hapi-fhir/Q8J2BITYqg4

…e to each other are created in the same transaction
@codecov
Copy link

codecov bot commented Nov 27, 2019

Codecov Report

Merging #1609 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1609      +/-   ##
============================================
- Coverage     79.05%   79.04%   -0.01%     
+ Complexity    13293    13291       -2     
============================================
  Files           920      920              
  Lines         51131    51131              
  Branches       8285     8285              
============================================
- Hits          40420    40416       -4     
- Misses         7538     7540       +2     
- Partials       3173     3175       +2
Impacted Files Coverage Δ Complexity Δ
...e/src/main/java/ca/uhn/fhir/parser/BaseParser.java 84.8% <100%> (-0.27%) 211 <0> (ø)
.../java/ca/uhn/fhir/rest/param/QualifierDetails.java 75% <0%> (-1.67%) 25% <0%> (-1%)
.../java/ca/uhn/fhir/rest/client/impl/BaseClient.java 92.24% <0%> (-0.39%) 69% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df57d24...62ba03b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant