Avoid logging message payloads that contain sensitive data (#4537)

Don't log payloads - they may contain sensitive data.
hapifhir · Feb 10, 2023 · fb0512f · fb0512f
1 parent 03ccf3e
commit fb0512f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/...src/main/resources/ca/uhn/hapi/fhir/changelog/6_4_0/4537-message-to-string-redaction.yaml b/...src/main/resources/ca/uhn/hapi/fhir/changelog/6_4_0/4537-message-to-string-redaction.yaml
@@ -0,0 +1,5 @@
+---
+type: change
+issue: 4537
+title: "ResourceDeliveryMessage no longer includes the payload in toString().
+ This avoids leaking sensitive data to logs and other channels."
diff --git a/...hir-storage/src/main/java/ca/uhn/fhir/jpa/subscription/model/ResourceDeliveryMessage.java b/...hir-storage/src/main/java/ca/uhn/fhir/jpa/subscription/model/ResourceDeliveryMessage.java
@@ -128,7 +128,8 @@ public void setPartitionId(RequestPartitionId thePartitionId) {
  public String toString() {
  return new ToStringBuilder(this)
  .append("mySubscription", mySubscription)
- .append("myPayloadString", myPayloadString)
+ // it isn't safe to log payloads
+ .append("myPayloadString", "[Not Logged]")
  .append("myPayload", myPayloadDecoded)
  .append("myPayloadId", myPayloadId)
  .append("myPartitionId", myPartitionId)