History count fix #739
Open
History count fix #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed history_count_mode ENUM setup
jkiddo
reviewed
Sep 28, 2024
| @@ -71,6 +71,7 @@ public class AppProperties { | |||
| private List<String> supported_resource_types = new ArrayList<>(); | |||
| private List<Bundle.BundleType> allowed_bundle_types = null; | |||
| private Boolean narrative_enabled = true; | |||
| private String history_count_mode = "CACHED_ONLY_WITHOUT_OFFSET"; | |||
There was a problem hiding this comment.
This should be bound to HistoryCountModeEnum like in
making it more strongly typed
jkiddo
requested changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening this old PR after addressing changes #500
Resolves this issue #433
During integration testing, it is useful to make rapid search history queries, but unless this flag can be configured we are forced to use the default of waiting 1 minute for the history cache to clear. Instead, during integration test we should always be getting the actual data from the db.